Remove of unused imports

Policy failures:   
Code warning
- failed on resource DispatchArticleController.java. Reason: The local variable article is never read, line 5
Override reason:   
yu
This commit is contained in:
Frederic Debuire
2008-02-13 14:30:40 +00:00
parent 305696e066
commit 074fe4f6d6
23 changed files with 114 additions and 109 deletions

View File

@@ -1,6 +1,7 @@
package org.yacos.auth; package org.yacos.auth;
import java.util.List; import java.util.List;
import org.acegisecurity.GrantedAuthority; import org.acegisecurity.GrantedAuthority;
import org.acegisecurity.GrantedAuthorityImpl; import org.acegisecurity.GrantedAuthorityImpl;
import org.yacos.core.users.Role; import org.yacos.core.users.Role;

View File

@@ -2,18 +2,23 @@ package org.yacos.web.PCmember.controller;
import java.util.*; import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import org.springframework.validation.BindException; import org.springframework.validation.BindException;
import org.springframework.web.servlet.ModelAndView; import org.springframework.web.servlet.ModelAndView;
import org.springframework.web.servlet.mvc.SimpleFormController; import org.springframework.web.servlet.mvc.SimpleFormController;
import org.springframework.web.servlet.view.RedirectView; import org.springframework.web.servlet.view.RedirectView;
import org.yacos.core.article.*; import org.yacos.core.article.Article;
import org.yacos.core.article.IArticleManager;
import org.yacos.core.article.Preference;
import org.yacos.core.conferences.IConferenceManager; import org.yacos.core.conferences.IConferenceManager;
import org.yacos.core.users.IUserManager; import org.yacos.core.users.IUserManager;
import org.yacos.core.users.User; import org.yacos.core.users.User;

View File

@@ -1,14 +1,15 @@
package org.yacos.web.PCmember.controller; package org.yacos.web.PCmember.controller;
import org.springframework.web.servlet.mvc.SimpleFormController; import java.io.IOException;
import org.springframework.web.servlet.ModelAndView;
import javax.servlet.ServletException; import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import java.io.IOException; import org.springframework.web.servlet.ModelAndView;
import org.springframework.web.servlet.mvc.SimpleFormController;
public class ChoosePreferenceControllerOK extends SimpleFormController { public class ChoosePreferenceControllerOK extends SimpleFormController {

View File

@@ -1,6 +1,7 @@
package org.yacos.web.PCmember.controller; package org.yacos.web.PCmember.controller;
import java.io.IOException; import java.io.IOException;
import javax.servlet.ServletException; import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;

View File

@@ -2,8 +2,10 @@ package org.yacos.web.PCmember.controller;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Collection; import java.util.Collection;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import org.springframework.validation.BindException; import org.springframework.validation.BindException;

View File

@@ -2,16 +2,20 @@ package org.yacos.web.PCmember.controller;
import java.util.*; import java.util.ArrayList;
import java.util.List;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import org.springframework.validation.BindException; import org.springframework.validation.BindException;
import org.springframework.web.servlet.ModelAndView; import org.springframework.web.servlet.ModelAndView;
import org.springframework.web.servlet.mvc.SimpleFormController; import org.springframework.web.servlet.mvc.SimpleFormController;
import org.springframework.web.servlet.view.RedirectView; import org.springframework.web.servlet.view.RedirectView;
import org.yacos.core.article.*; import org.yacos.core.article.Article;
import org.yacos.core.article.IArticleManager;
import org.yacos.core.conferences.Conference; import org.yacos.core.conferences.Conference;
import org.yacos.core.conferences.IConferenceManager; import org.yacos.core.conferences.IConferenceManager;
import org.yacos.core.evaluation.Criterion; import org.yacos.core.evaluation.Criterion;
@@ -20,10 +24,7 @@ import org.yacos.core.evaluation.Rating;
import org.yacos.core.evaluation.Report; import org.yacos.core.evaluation.Report;
import org.yacos.core.users.IUserManager; import org.yacos.core.users.IUserManager;
import org.yacos.core.users.User; import org.yacos.core.users.User;
//import org.yacos.web.author.form.*;
import org.yacos.web.PCmember.form.FormEvaluation; import org.yacos.web.PCmember.form.FormEvaluation;
import org.yacos.web.PCmember.form.SimpleCriterion; import org.yacos.web.PCmember.form.SimpleCriterion;
import org.yacos.web.system.session.SessionService; import org.yacos.web.system.session.SessionService;

View File

@@ -1,20 +1,21 @@
package org.yacos.web.PCmember.controller; package org.yacos.web.PCmember.controller;
import org.springframework.web.servlet.mvc.SimpleFormController; import java.io.IOException;
import org.springframework.web.servlet.ModelAndView; import java.util.List;
import javax.servlet.ServletException; import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import java.io.IOException; import org.springframework.web.servlet.ModelAndView;
import java.util.List; import org.springframework.web.servlet.mvc.SimpleFormController;
import org.yacos.web.system.controller.NoConferenceSelectedException;
import org.yacos.web.system.session.SessionService;
import org.yacos.core.article.Article; import org.yacos.core.article.Article;
import org.yacos.core.article.IArticleManager; import org.yacos.core.article.IArticleManager;
import org.yacos.core.exceptions.ConferenceDoesntExistException; import org.yacos.core.exceptions.ConferenceDoesntExistException;
import org.yacos.web.system.controller.NoConferenceSelectedException;
import org.yacos.web.system.session.SessionService;
public class ListArticleController extends SimpleFormController { public class ListArticleController extends SimpleFormController {

View File

@@ -1,20 +1,21 @@
package org.yacos.web.PCmember.controller; package org.yacos.web.PCmember.controller;
import org.springframework.web.servlet.mvc.SimpleFormController; import java.io.IOException;
import org.springframework.web.servlet.ModelAndView; import java.util.List;
import javax.servlet.ServletException; import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import java.io.IOException; import org.springframework.web.servlet.ModelAndView;
import java.util.List; import org.springframework.web.servlet.mvc.SimpleFormController;
import org.yacos.web.system.controller.NoConferenceSelectedException;
import org.yacos.web.system.session.SessionService;
import org.yacos.core.article.Article; import org.yacos.core.article.Article;
import org.yacos.core.article.IArticleManager; import org.yacos.core.article.IArticleManager;
import org.yacos.core.exceptions.ConferenceDoesntExistException; import org.yacos.core.exceptions.ConferenceDoesntExistException;
import org.yacos.web.system.controller.NoConferenceSelectedException;
import org.yacos.web.system.session.SessionService;
public class ListEvaluationController extends SimpleFormController { public class ListEvaluationController extends SimpleFormController {

View File

@@ -1,18 +1,20 @@
package org.yacos.web.PCmember.controller; package org.yacos.web.PCmember.controller;
import org.springframework.web.servlet.mvc.SimpleFormController; import java.io.IOException;
import org.springframework.web.servlet.ModelAndView; import java.util.List;
import javax.servlet.ServletException; import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import java.io.IOException; import org.springframework.web.servlet.ModelAndView;
import java.util.List; import org.springframework.web.servlet.mvc.SimpleFormController;
import org.yacos.web.system.controller.NoConferenceSelectedException;
import org.yacos.core.evaluation.IEvaluationManager; import org.yacos.core.evaluation.IEvaluationManager;
import org.yacos.core.evaluation.Rating; import org.yacos.core.evaluation.Rating;
import org.yacos.core.evaluation.Report; import org.yacos.core.evaluation.Report;
import org.yacos.web.system.controller.NoConferenceSelectedException;
public class ListReportController extends SimpleFormController { public class ListReportController extends SimpleFormController {

View File

@@ -1,17 +1,19 @@
package org.yacos.web.PCmember.controller; package org.yacos.web.PCmember.controller;
import org.springframework.web.servlet.mvc.SimpleFormController; import java.io.IOException;
import org.springframework.web.servlet.ModelAndView; import java.util.List;
import javax.servlet.ServletException; import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import java.io.IOException; import org.springframework.web.servlet.ModelAndView;
import java.util.List; import org.springframework.web.servlet.mvc.SimpleFormController;
import org.yacos.web.system.session.SessionService;
import org.yacos.core.article.Article; import org.yacos.core.article.Article;
import org.yacos.core.article.IArticleManager; import org.yacos.core.article.IArticleManager;
import org.yacos.core.exceptions.ConferenceDoesntExistException; import org.yacos.core.exceptions.ConferenceDoesntExistException;
import org.yacos.web.system.session.SessionService;
public class ValidateArticleController extends SimpleFormController { public class ValidateArticleController extends SimpleFormController {

View File

@@ -1,23 +1,19 @@
package org.yacos.web.PCmember.controller; package org.yacos.web.PCmember.controller;
import org.springframework.web.servlet.mvc.SimpleFormController; import java.lang.reflect.UndeclaredThrowableException;
import org.springframework.web.servlet.view.RedirectView;
import org.springframework.web.servlet.ModelAndView;
import javax.servlet.ServletException; import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import java.io.IOException; import org.springframework.web.servlet.ModelAndView;
import java.lang.reflect.UndeclaredThrowableException; import org.springframework.web.servlet.mvc.SimpleFormController;
import java.util.List; import org.springframework.web.servlet.view.RedirectView;
import org.yacos.web.system.controller.NoConferenceSelectedException;
import org.yacos.web.system.session.SessionService;
import org.yacos.core.article.Article; import org.yacos.core.article.Article;
import org.yacos.core.article.IArticleManager; import org.yacos.core.article.IArticleManager;
import org.yacos.core.article.Article.State; import org.yacos.core.article.Article.State;
import org.yacos.core.exceptions.ConferenceDoesntExistException;
public class ValideOrRejectController extends SimpleFormController { public class ValideOrRejectController extends SimpleFormController {

View File

@@ -1,13 +1,15 @@
package org.yacos.web.author.controller; package org.yacos.web.author.controller;
import org.springframework.web.servlet.mvc.SimpleFormController; import java.io.IOException;
import org.springframework.web.servlet.ModelAndView;
import javax.servlet.ServletException; import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import java.io.IOException; import org.springframework.web.servlet.ModelAndView;
import org.springframework.web.servlet.mvc.SimpleFormController;
public class MainController extends SimpleFormController { public class MainController extends SimpleFormController {

View File

@@ -1,20 +1,22 @@
package org.yacos.web.author.controller; package org.yacos.web.author.controller;
import org.springframework.web.servlet.mvc.SimpleFormController;
import org.springframework.web.servlet.ModelAndView;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import java.io.IOException; import java.io.IOException;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.springframework.web.servlet.ModelAndView;
import org.springframework.web.servlet.mvc.SimpleFormController;
import org.yacos.core.article.Article;
import org.yacos.core.article.IArticleManager;
import org.yacos.web.author.form.ArticleBean; import org.yacos.web.author.form.ArticleBean;
import org.yacos.web.system.controller.NoConferenceSelectedException; import org.yacos.web.system.controller.NoConferenceSelectedException;
import org.yacos.web.system.session.SessionService; import org.yacos.web.system.session.SessionService;
import org.yacos.core.article.Article;
import org.yacos.core.article.IArticleManager;
public class ManageArticleController extends SimpleFormController { public class ManageArticleController extends SimpleFormController {

View File

@@ -5,9 +5,11 @@ import java.io.FileNotFoundException;
import java.io.FileOutputStream; import java.io.FileOutputStream;
import java.io.IOException; import java.io.IOException;
import java.util.ArrayList; import java.util.ArrayList;
import javax.servlet.ServletException; import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import org.springframework.validation.BindException; import org.springframework.validation.BindException;

View File

@@ -1,13 +1,15 @@
package org.yacos.web.author.controller; package org.yacos.web.author.controller;
import org.springframework.web.servlet.mvc.SimpleFormController; import java.io.IOException;
import org.springframework.web.servlet.ModelAndView;
import javax.servlet.ServletException; import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import java.io.IOException; import org.springframework.web.servlet.ModelAndView;
import org.springframework.web.servlet.mvc.SimpleFormController;
public class SArticleControllerOK extends SimpleFormController { public class SArticleControllerOK extends SimpleFormController {

View File

@@ -7,55 +7,37 @@ import org.yacos.web.author.form.FormSubmission;
public class ValidateSubmission implements Validator { public class ValidateSubmission implements Validator {
@SuppressWarnings("unchecked")
public boolean supports(Class arg0) { public boolean supports(Class arg0) {
return FormSubmission.class.isAssignableFrom(arg0); return FormSubmission.class.isAssignableFrom(arg0);
} }
public void validate(Object arg0, Errors arg1) { public void validate(Object arg0, Errors arg1) {
FormSubmission sub=(FormSubmission)arg0; FormSubmission sub=(FormSubmission)arg0;
String title=sub.getTitle(); String title=sub.getTitle();
String theme=sub.getTheme(); String theme=sub.getTheme();
String abs=sub.getAbstractText(); String abs=sub.getAbstractText();
String mainauthor=sub.getMainauthor();
String file=sub.getFile().getName();
if (title== null || title.trim().length() == 0) { if (title== null || title.trim().length() == 0) {
arg1.rejectValue("title", arg1.rejectValue("title",
"submissionArticle.title", "submissionArticle.title",
"Le title est n<><6E>cessaire !"); "Le title est n<><6E>cessaire !");
} }
if (theme==null|theme.trim().length()==0) if (theme==null|theme.trim().length()==0)
{ {
arg1.rejectValue("theme", "submissionArticle.theme"); arg1.rejectValue("theme", "submissionArticle.theme");
} }
if (abs==null|abs.trim().length()==0) if (abs==null|abs.trim().length()==0)
{ arg1.rejectValue("abstractText", "submissionArticle.abstractText", "text is not nullable"); { arg1.rejectValue("abstractText", "submissionArticle.abstractText", "text is not nullable");
} }
/*if (mainauthor==null|mainauthor.trim().length()==0)
{
arg1.rejectValue("mainauthor", "submissionArticle.mainauthor");
}*/
/* if (file==null|file.trim().length()==0)
{
arg1.rejectValue("file", "submissionArticle.file");
}
*/
} }
} }

View File

@@ -8,8 +8,10 @@ import java.util.List;
import java.util.Set; import java.util.Set;
import java.util.regex.Matcher; import java.util.regex.Matcher;
import java.util.regex.Pattern; import java.util.regex.Pattern;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import org.springframework.mail.MailSendException; import org.springframework.mail.MailSendException;
@@ -246,8 +248,8 @@ public class AddConferenceController extends AbstractWizardFormController {
String action = request.getParameter("action"); String action = request.getParameter("action");
if (action == null || action.equals("")) if (action == null || action.equals(""))
{ {
// TODO : tester ici si le gars a le droit d'<27>tre ici // TODO : tester ici si le gars a le droit d'<27>tre ici
// a-t-il le droit de cr<63>er une conf<6E>rence ? // a-t-il le droit de cr<63>er une conf<6E>rence ?
criteria = new HashSet<CriterionBean>(); criteria = new HashSet<CriterionBean>();
criteriaAll = new HashSet<CriterionBean>(); criteriaAll = new HashSet<CriterionBean>();

View File

@@ -1,6 +1,5 @@
package org.yacos.web.chairman.controller; package org.yacos.web.chairman.controller;
import org.yacos.core.article.Preference.PreferenceType;
public class PCMemberBean { public class PCMemberBean {
private String login; private String login;

View File

@@ -12,6 +12,7 @@ import org.yacos.web.chairman.form.FormConference;
public class ConferenceValidator implements Validator { public class ConferenceValidator implements Validator {
@SuppressWarnings("unchecked")
public boolean supports(Class commandClass) { public boolean supports(Class commandClass) {
return FormConference.class.isAssignableFrom(commandClass); return FormConference.class.isAssignableFrom(commandClass);
} }

View File

@@ -4,9 +4,11 @@ import java.io.BufferedInputStream;
import java.io.File; import java.io.File;
import java.io.FileInputStream; import java.io.FileInputStream;
import java.io.InputStream; import java.io.InputStream;
import javax.servlet.ServletContext; import javax.servlet.ServletContext;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import org.springframework.util.FileCopyUtils; import org.springframework.util.FileCopyUtils;
import org.springframework.web.servlet.ModelAndView; import org.springframework.web.servlet.ModelAndView;
import org.springframework.web.servlet.mvc.Controller; import org.springframework.web.servlet.mvc.Controller;

View File

@@ -5,6 +5,7 @@ import java.util.Map;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import org.springframework.web.servlet.ModelAndView; import org.springframework.web.servlet.ModelAndView;
import org.springframework.web.servlet.mvc.Controller; import org.springframework.web.servlet.mvc.Controller;
import org.springframework.web.servlet.view.RedirectView; import org.springframework.web.servlet.view.RedirectView;

View File

@@ -6,7 +6,6 @@ package org.yacos.web.system.controller;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import org.acegisecurity.providers.dao.UserCache;
import org.springframework.validation.BindException; import org.springframework.validation.BindException;
import org.springframework.web.servlet.ModelAndView; import org.springframework.web.servlet.ModelAndView;
import org.springframework.web.servlet.mvc.SimpleFormController; import org.springframework.web.servlet.mvc.SimpleFormController;

View File

@@ -1,12 +1,11 @@
package org.yacos.web.system.session; package org.yacos.web.system.session;
import java.util.List;
import javax.naming.Context; import javax.naming.Context;
import javax.naming.InitialContext; import javax.naming.InitialContext;
import javax.naming.NamingException; import javax.naming.NamingException;
import javax.servlet.ServletContext; import javax.servlet.ServletContext;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import org.acegisecurity.Authentication; import org.acegisecurity.Authentication;
import org.acegisecurity.context.SecurityContextHolder; import org.acegisecurity.context.SecurityContextHolder;
import org.acegisecurity.providers.UsernamePasswordAuthenticationToken; import org.acegisecurity.providers.UsernamePasswordAuthenticationToken;
@@ -18,7 +17,6 @@ import org.yacos.core.conferences.Conference;
import org.yacos.core.conferences.IConferenceManager; import org.yacos.core.conferences.IConferenceManager;
import org.yacos.core.users.IUserManager; import org.yacos.core.users.IUserManager;
import org.yacos.core.users.User; import org.yacos.core.users.User;
import org.yacos.core.users.Role;
/** /**
* Provides Session related Services * Provides Session related Services