From 0a1a20437caa50a750037b99e70ca7a9c70edd1d Mon Sep 17 00:00:00 2001 From: Maxime Dagnicourt Date: Thu, 10 Jan 2008 16:28:20 +0000 Subject: [PATCH] Policy failures: Code warning - failed on resource Conference.java. Reason: The import javax.persistence.JoinColumn is never used, line 12 - failed on resource Conference.java. Reason: The import javax.persistence.OneToOne is never used, line 14 - failed on resource Conference.java. Reason: The import org.yacos.core.users.User is never used, line 20 - failed on resource ConferenceManagerBean.java. Reason: Type safety: The expression of type List needs unchecked conversion to conform to List, line 6 Override reason: ds --- .../yacos/core/conferences/Conference.java | 18 ++++++++++------ .../conferences/ConferenceManagerBean.java | 21 +++++++++++-------- .../core/conferences/IConferenceManager.java | 10 ++++++--- 3 files changed, 31 insertions(+), 18 deletions(-) diff --git a/YACOSCore/ejbModule/org/yacos/core/conferences/Conference.java b/YACOSCore/ejbModule/org/yacos/core/conferences/Conference.java index a964727..e6ca4be 100644 --- a/YACOSCore/ejbModule/org/yacos/core/conferences/Conference.java +++ b/YACOSCore/ejbModule/org/yacos/core/conferences/Conference.java @@ -9,12 +9,15 @@ import javax.persistence.Entity; import javax.persistence.GeneratedValue; import javax.persistence.GenerationType; import javax.persistence.Id; +import javax.persistence.JoinColumn; import javax.persistence.OneToMany; +import javax.persistence.OneToOne; import javax.persistence.Temporal; import javax.persistence.TemporalType; import org.yacos.core.article.Article; import org.yacos.core.users.Role; +import org.yacos.core.users.User; @Entity @@ -45,17 +48,18 @@ public class Conference implements Serializable{ @OneToMany(targetEntity=Role.class,mappedBy="conference") private Collection roles; - /*@OneToOne(targetEntity=User.class,optional=true) +/* @OneToOne(targetEntity=User.class,optional=true) @JoinColumn(name="chairman_id",nullable=true) private User chairman; - */ +*/ @OneToMany(targetEntity=Article.class,mappedBy="conference") private Collection
articles; - +/* /** * @return the chairman */ - /*@OneToOne(targetEntity=User.class,optional=true) + /* + @OneToOne(targetEntity=User.class,optional=true) @JoinColumn(name="chairman_id",nullable=true) public User getChairman() { return chairman; @@ -64,13 +68,13 @@ public class Conference implements Serializable{ /** * @param chairman the chairman to set */ - /* +/* @OneToOne(targetEntity=User.class,optional=true) @JoinColumn(name="chairman_id",nullable=true) public void setChairman(User chairman) { this.chairman = chairman; } - */ +*/ @Temporal(TemporalType.DATE) public Date getDataAbstract() { return dateAbstract; @@ -163,10 +167,12 @@ public class Conference implements Serializable{ return articles; } + @OneToMany(targetEntity=Role.class,mappedBy="conference") public Collection getRoles() { return roles; } + @OneToMany(targetEntity=Role.class,mappedBy="conference") public void setRoles(Collection roles) { this.roles = roles; } diff --git a/YACOSCore/ejbModule/org/yacos/core/conferences/ConferenceManagerBean.java b/YACOSCore/ejbModule/org/yacos/core/conferences/ConferenceManagerBean.java index 7837b48..9450ee9 100644 --- a/YACOSCore/ejbModule/org/yacos/core/conferences/ConferenceManagerBean.java +++ b/YACOSCore/ejbModule/org/yacos/core/conferences/ConferenceManagerBean.java @@ -1,11 +1,13 @@ package org.yacos.core.conferences; import java.util.Collection; +import java.util.Date; import java.util.List; import javax.ejb.Stateless; import javax.persistence.EntityManager; import javax.persistence.PersistenceContext; +import javax.persistence.Query; import org.yacos.core.article.Article; import org.yacos.core.users.Role; @@ -16,8 +18,10 @@ public class ConferenceManagerBean implements IConferenceManager { @PersistenceContext EntityManager em; - public void addConference(Conference conf) { + public Conference addConference(String titre, String descirption, String infoComplementray, Date dataAbstract, Date dateArticle, Date dateEvaluation, Date dateStart, Date dateEnd) { + Conference conf = new Conference(titre, descirption, infoComplementray, dataAbstract, dateArticle, dateEvaluation, dateStart, dateEnd); em.persist(conf); + return conf; } @SuppressWarnings("unchecked") @@ -53,17 +57,16 @@ public class ConferenceManagerBean implements IConferenceManager { em.persist(role); } - public void getRoles(Role role, User user) { - // TODO Auto-generated method stub - - } - - public void getRoles(User user, Conference conf) { - // TODO Auto-generated method stub - + public List getRoles(User user, Conference conf) { + Query query = em.createQuery("from Role role where conference = ? and user = ?"); + query.setParameter(0, conf); + query.setParameter(1, user); + + return query.getResultList(); } + public void removeRoleForUser(Role role) { // TODO Auto-generated method stub diff --git a/YACOSCore/ejbModule/org/yacos/core/conferences/IConferenceManager.java b/YACOSCore/ejbModule/org/yacos/core/conferences/IConferenceManager.java index dba46fe..5adbc22 100644 --- a/YACOSCore/ejbModule/org/yacos/core/conferences/IConferenceManager.java +++ b/YACOSCore/ejbModule/org/yacos/core/conferences/IConferenceManager.java @@ -1,6 +1,8 @@ package org.yacos.core.conferences; import java.util.Collection; +import java.util.Date; +import java.util.List; import javax.ejb.Remote; @@ -12,18 +14,20 @@ import org.yacos.core.users.User; public interface IConferenceManager { //CRUD methodes - public void addConference(Conference conf); + public Conference addConference(String titre, String descirption, String infoComplementray, Date dataAbstract, Date dateArticle, Date dateEvaluation, Date dateStart, Date dateEnd); public Conference getConference(Integer id); public Collection getConferences(); public void remove(Conference conf); public void update(Conference conf); //article methodes - public void addArticle(User user); + //FIXME + //methode a gicler ? + //public void addArticle(User user); public Collection
getArticles(Integer id); //role methode public void addRoleForUser(Role.RoleType roleType, User user, Conference conf); public void removeRoleForUser(Role role); - public void getRoles(User user, Conference conf); + public List getRoles(User user, Conference conf); }