Plein de modif

Policy failures:   
Code warning
- failed on resource DispatchArticleController.java. Reason: ArrayList is a raw type. References to generic type ArrayList<E> should be parameterized, line 37
- failed on resource DispatchArticleController.java. Reason: ArrayList is a raw type. References to generic type ArrayList<E> should be parameterized, line 38
- failed on resource DispatchArticleController.java. Reason: ArrayList is a raw type. References to generic type ArrayList<E> should be parameterized, line 62
- failed on resource DispatchArticleController.java. Reason: ArrayList is a raw type. References to generic type ArrayList<E> should be parameterized, line 63
- failed on resource ChoosePreferenceControllerOK.java. Reason: The import java.util.Date is never used, line 14
... and more.  
Override reason:   
haha

YACOSWeb/WebContent/WEB-INF/jsp/choosePreference.jsp

@@ -6,25 +6,25 @@
 <h2 align="center"><fmt:message key="preference.title" /></h2>
 
 
-<form:form method="post" commandName="choose">  
+<form:form method="post" commandName="choosePreference">  
 <c:if test="${empty requestScope['articleList']}"> 
 	<table>
     <c:forEach items="${articleList}" var="article" varStatus="i">
     
     <tr>
-        <td><a href="<c:url value="detailArticle.htm"/>">${article.title}"</a></td>
+        <td><a href="<c:url value="detailArticle.htm"/>">${article.title}</a></td>
         <form:hidden path="preferences[${i.index}].article" />
         <form:hidden path="preferences[${i.index}].pcMember" />
 	    <td><fmt:message key="preference.like"/></td>
-	    <td><form:radiobutton id="A" path="preferences[${i.index}].preference" /><fmt:message key="preference.like"/></td>
+	    <td><form:radiobutton path="preferences[${i.index}].preference" value="Like"/></td>
 	    <td><fmt:message key="preference.indifferent"/></td>
-	    <td><form:radiobutton id="B" path="preferences[${i.index}].preference" /><fmt:message key="preference.indifferent"/></td>
+	    <td><form:radiobutton path="preferences[${i.index}].preference" value="Indifferent"/></td>
 	    <td><fmt:message key="preference.dislike"/></td>
-	    <td><form:radiobutton id="C" path="preferences[${i.index}].preference" /><fmt:message key="preference.dislike"/></td> 
+	    <td><form:radiobutton path="preferences[${i.index}].preference" value="Dislike"/></td> 
      </tr>
-     <input type="submit" value="<fmt:message key="button.OK"/>">
    </c:forEach>
    </table>
+   <input type="submit" value="<fmt:message key="button.OK"/>"/>
 </c:if>
 </form:form>
 

YACOSWeb/WebContent/WEB-INF/jsp/submissionArticle.jsp

@@ -45,8 +45,8 @@ function Supprimer(form) {
 	
 	<br /><br />
 	
-	<input type="reset" value=<fmt:message key="button.reset" />>
+	<input type="reset" value="<fmt:message key="button.reset" />"/>
-	<input type="submit" value=<fmt:message key="button.OK" />> <br/><br/>
+	<input type="submit" value="<fmt:message key="button.OK" />"/> <br/><br/>
 	
 </form:form>
 

YACOSWeb/WebContent/WEB-INF/yacos-servlet.xml

@@ -19,6 +19,8 @@
 	
 	<bean name="/submissionArticleOK.htm" class="org.yacos.web.author.controller.SArticleControllerOK" />
 	
+	<bean name="/choosePreferenceOK.htm" class="org.yacos.web.PCmember.controller.ChoosePreferenceControllerOK" />
+	
 	<bean name="/submissionArticle.htm" class="org.yacos.web.author.controller.SArticleController">
 		<property name="sessionForm" value="true" />
 		<property name="commandName" value="submissionArticle" />
@@ -30,18 +32,18 @@
 	
 	<bean name="/choosePreference.htm" class="org.yacos.web.PCmember.controller.ChoosePreferenceController">
 		<property name="sessionForm" value="true" />
-		<property name="commandName" value="choose"/>
+		<property name="commandName" value="choosePreference"/>
 		<property name="commandClass" value="org.yacos.web.PCmember.form.FormPreference" />
 		<property name="formView" value="choosePreference" />
 		<property name="successView" value="choosePreferenceOK.htm" />
 		<property name="articleManager" ref="articleManager" />
 	</bean>
 	
-	<bean name="/dipatchArticle.htm" class="org.yacos.web.PCmember.controller.DispatchArticleController">
+	<bean name="/dispatchArticle.htm" class="org.yacos.web.PCmember.controller.DispatchArticleController">
 		<property name="sessionForm" value="true" />
 		<property name="commandName" value="formDispatcher"/>
 		<property name="commandClass" value="org.yacos.web.PCmember.form.FormDispatcher" />
-		<property name="formView" value="dispatchArticle.htm" />
+		<property name="formView" value="dispatchArticle" />
 		<property name="successView" value="dispatchArticle.htm" />
 		<property name="articleManager" ref="articleManager" />
 	</bean>

YACOSWeb/src/org/yacos/web/PCmember/controller/ChoosePreferenceController.java

@@ -33,8 +33,6 @@ public class ChoosePreferenceController  extends SimpleFormController {
 		
 		List<Article> articleList=new ArrayList<Article>();
 		
-		System.out.println("hihi");
-		
 		Article a=new Article(1,"j2ee in action","j2ee discussion","","",null,1); 
 		Article b=new Article(2,"php in action","php discussion","","",null,1);	
 		articleList.add(a);
@@ -55,13 +53,10 @@ public class ChoosePreferenceController  extends SimpleFormController {
 		List<Preference> listPreference=fp.getPreferences();
 		// to do with the part of core using preferenceManager 
 
-		return new ModelAndView("choosePreferenceOK");
+		return new ModelAndView(new RedirectView(getSuccessView()));
 
 	}
 
-
-
-
 	public IArticleManager getArticleManager() {
 		return articleManager;
 	}

YACOSWeb/src/org/yacos/web/PCmember/controller/ChoosePreferenceControllerOK.java

@@ -0,0 +1,28 @@
+package org.yacos.web.PCmember.controller;
+
+import org.springframework.web.servlet.mvc.SimpleFormController;
+import org.springframework.web.servlet.ModelAndView;
+
+import javax.servlet.ServletException;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+
+import java.io.IOException;
+import java.util.Date;
+
+public class ChoosePreferenceControllerOK extends SimpleFormController {
+
+    protected final Log logger = LogFactory.getLog(getClass());
+
+    public ModelAndView handleRequest(HttpServletRequest request, HttpServletResponse response)
+            throws ServletException, IOException {
+
+        logger.info("Returning choosePreference OK view");
+
+        return new ModelAndView("choosePreferenceOK");
+    }
+
+}

YACOSWeb/src/org/yacos/web/PCmember/controller/DispatchArticleController.java

@@ -73,7 +73,7 @@ public class DispatchArticleController extends SimpleFormController{
 		request.getSession().setAttribute("members",members);		
 		/*fin de test*/
 		
-		return new ModelAndView("dispachArticle", "articles",articles);
+		return new ModelAndView("dispatchArticle", "articles", articles);
 	}
 	
 	/*public ModelAndView handleRequest(HttpServletRequest arg0,