From 490b10c07cff59bd01f1dd46a2cdb86bde6a0d47 Mon Sep 17 00:00:00 2001
From: Frederic Debuire <frederic.debuire@gmail.com>
Date: Wed, 13 Feb 2008 11:20:01 +0000
Subject: [PATCH] =?UTF-8?q?Correction=20d'un=20probl=C3=A8me=20avec=20un?=
 =?UTF-8?q?=20rollback=20plac=C3=A9=20dans=20un=20finally=20Policy=20failu?=
 =?UTF-8?q?res:=20Code=20warning=20-=20failed=20on=20resource=20ArticleMan?=
 =?UTF-8?q?agerBean.java.=20Reason:=20Type=20safety:=20The=20expression=20?=
 =?UTF-8?q?of=20type=20List=20needs=20unchecked=20conversion=20to=20confor?=
 =?UTF-8?q?m=20to=20List<Article>,=20line=2015=20Override=20reason:=20yess?=
 =?UTF-8?q?s?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../yacos/core/article/ArticleManagerBean.java | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/YACOSCore/ejbModule/org/yacos/core/article/ArticleManagerBean.java b/YACOSCore/ejbModule/org/yacos/core/article/ArticleManagerBean.java
index c7863e1..0338722 100644
--- a/YACOSCore/ejbModule/org/yacos/core/article/ArticleManagerBean.java
+++ b/YACOSCore/ejbModule/org/yacos/core/article/ArticleManagerBean.java
@@ -86,12 +86,12 @@ public class ArticleManagerBean implements IArticleManager, Serializable {
 			persistentArticle.setSecondaryAuthors(article.getSecondaryAuthors());
 			ut.commit();
 		} catch (Exception e) {
-			e.printStackTrace();
-		} finally {
 			try {
 				ut.rollback();
-			} catch (Exception e) {
 				e.printStackTrace();
+			} catch (Exception e1) {
+				// TODO Auto-generated catch block
+				e1.printStackTrace();
 			}
 		}
 	}
@@ -163,11 +163,12 @@ public class ArticleManagerBean implements IArticleManager, Serializable {
 			
 			this.updateArticle(article);
 		} catch (Exception e) {
-			try{
+			try {
 				ut.rollback();
 			} catch (Exception e1) {
 				e1.printStackTrace();
 			}
+			e.printStackTrace();
 		}
 		//article.addPCMember(PCMember);
 	}
@@ -182,11 +183,12 @@ public class ArticleManagerBean implements IArticleManager, Serializable {
 			ut.commit();	
 			this.updateArticle(article);
 		} catch (Exception e) {
-			try{
+			try {
 				ut.rollback();
 			} catch (Exception e1) {
 				e1.printStackTrace();
 			}
+			e.printStackTrace();
 		}
 	}
 	
@@ -234,6 +236,7 @@ public class ArticleManagerBean implements IArticleManager, Serializable {
 			} catch (Exception e1) {
 				e1.printStackTrace();
 			}
+			e.printStackTrace();
 		}
 		return null;
 	}
@@ -331,6 +334,11 @@ public class ArticleManagerBean implements IArticleManager, Serializable {
 				em.persist(role);
 				ut.commit();
 			} catch (Exception e) {
+				try {
+					ut.rollback();
+				} catch (Exception e1) {
+					e1.printStackTrace();
+				}
 				e.printStackTrace();
 			}
 		}