corriger ratings : pour que les reports affichent les ratings differents

Policy failures:   
Code warning
- failed on resource ListReportController.java. Reason: ArrayList is a raw type. References to generic type ArrayList<E> should be parameterized, line 53
- failed on resource ListReportController.java. Reason: List is a raw type. References to generic type List<E> should be parameterized, line 53
- failed on resource ListReportController.java. Reason: Type safety: The method add(Object) belongs to the raw type List. References to generic type List<E> should be parameterized, line 5
Override reason:
This commit is contained in:
Jialin Wang
2008-02-25 00:06:57 +00:00
parent 736347ba9e
commit 6a7919a57f
3 changed files with 28 additions and 9 deletions

View File

@@ -14,7 +14,8 @@
</c:when>
<c:otherwise>
<c:forEach items="${listReport}" var="report">
<c:forEach items="${listReport}" var="report" varStatus="current">
<table>
<tr>
<td><fmt:message key="report.referee" />: ${report.referee.firstName} ${report.referee.lastName}</td>
@@ -24,7 +25,7 @@
<td>${report.article.title}</td>
</tr>
<c:forEach items="${rtgs}" var="rating">
<c:forEach items="${container[current.index]}" var="rating">
<tr>
<td><fmt:message key="evaluation.note" /></td>
<td>${rating.criterion.name} is:</td>
@@ -43,6 +44,7 @@
</tr>
</table>
<hr>
</c:forEach>
</c:otherwise>

View File

@@ -80,8 +80,8 @@ public class EvaluationController extends SimpleFormController {
String articleId = request.getParameter("id");
String action = request.getParameter("action");
// TODO : v<EFBFBD>rifier que le gars a le droit d'<EFBFBD>valuer cette article
// TODO : s'il existe d<EFBFBD>j<EFBFBD> une <EFBFBD>val, mais que l'action est pas modify, virer le gars
// TODO : verifier que le gars a le droit d'evaluer cette article
// TODO : s'il existe deja une al, mais que l'action est pas modify, virer le gars
if (action == null || action.equals("")) {

View File

@@ -1,6 +1,7 @@
package org.yacos.web.PCmember.controller;
import java.io.IOException;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
@@ -45,12 +46,28 @@ public class ListReportController extends SimpleFormController {
if (listReport.isEmpty())
return new ModelAndView("listReport", "listReport", null);
model.put("listReport", listReport);
List<Rating> ratings = evaluationManager.getRatingForReport(listReport.get(listReport.size() - 1).getId());
model.put("rtgs", ratings);
List container=new ArrayList();
for (int i=0; i<=listReport.size()-1;i++){
List<Rating> ratings = evaluationManager.getRatingForReport(listReport.get(i).getId());
container.add(ratings);
}
model.put("container", container);
model.put("whereIcome", request.getHeader("REFERER"));
/* double[] moyennes=new double[listReport.size()];
for (Rating rt : ratings)
{
}*/
return new ModelAndView("listReport", model);
}