christiancorsano/yacos
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Policy failures:

Browse Source 
Code warning
- failed on resource Article.java. Reason: The assignment to variable id has no effect, line 75
- failed on resource ArticleManagerBean.java. Reason: The import java.util.Collection is never used, line 5
- failed on resource Preference.java. Reason: The import javax.persistence.Entity is never used, line 6
- failed on resource Delegation.java. Reason: The import javax.persistence.Entity is never used, line 8
- failed on resource Preference.java. Reason: The import javax.persistence.Id is never used, line 7
... and more.  
Override reason:   
e
This commit is contained in:
Maxime Dagnicourt
2007-12-16 15:11:29 +00:00
parent cf314b1d4c
commit 816c6adf18
4 changed files with 98 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
YACOSCore/ejbModule/org/yacos/core/article/Article.java
View File

@@ -3,27 +3,24 @@ package org.yacos.core.article;
import java.io.Serializable; import java.io.Serializable;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Collection; import java.util.Collection;
import javax.persistence.Entity; import javax.persistence.*;
import javax.persistence.GeneratedValue;
import javax.persistence.GenerationType;
import javax.persistence.Id;
import javax.persistence.JoinColumn;
import javax.persistence.JoinTable;
import javax.persistence.ManyToMany;
import javax.persistence.ManyToOne;
import org.yacos.core.conferences.Conference; import org.yacos.core.conferences.Conference;
import org.yacos.core.users.User; import org.yacos.core.users.User;
@Entity //@Entity
public class Article implements Serializable { public class Article implements Serializable {
/** /**
* *
*/ */
private static final long serialVersionUID = 1L; private static final long serialVersionUID = 1L;
@Id // @Id
@GeneratedValue(strategy=GenerationType.AUTO) // @GeneratedValue(strategy=GenerationType.AUTO)
private int id; private int id;
private String title; private String title;
private String topic; private String topic;
@@ -34,30 +31,30 @@ public class Article implements Serializable {
/** /**
* The conference this article has been submitted for * The conference this article has been submitted for
*/ */
@ManyToOne(targetEntity=Conference.class) //@ManyToOne(targetEntity=Conference.class)
@JoinColumn(name="conference_id",nullable=false) //@JoinColumn(name="conference_id",nullable=false)
private Conference conference; private Conference conference;
/** /**
* The referees reviewing this article * The referees reviewing this article
*/ */
@ManyToMany(targetEntity=User.class) /*@ManyToMany(targetEntity=User.class)
@JoinTable( @JoinTable(
name="articles_referees_map", name="articles_referees_map",
joinColumns=@JoinColumn(name="user_id"), joinColumns=@JoinColumn(name="user_id"),
inverseJoinColumns=@JoinColumn(name="article_id") inverseJoinColumns=@JoinColumn(name="article_id")
) )*/
private Collection<User> referees; private Collection<User> referees;
/** /**
* The PC Members responsible for this article evaluation * The PC Members responsible for this article evaluation
*/ */
@ManyToMany(targetEntity=User.class) /*@ManyToMany(targetEntity=User.class)
@JoinTable( @JoinTable(
name="articles_pcmembers_map", name="articles_pcmembers_map",
joinColumns=@JoinColumn(name="user_id"), joinColumns=@JoinColumn(name="user_id"),
inverseJoinColumns=@JoinColumn(name="article_id") inverseJoinColumns=@JoinColumn(name="article_id")
) )*/
private Collection<User> pcMembers; private Collection<User> pcMembers;
private int state; private int state;
@@ -68,6 +65,8 @@ public class Article implements Serializable {
public Article() { public Article() {
secondaryAuthors = new ArrayList<String>(); secondaryAuthors = new ArrayList<String>();
referees = new ArrayList<User>();
pcMembers = new ArrayList<User>();
} }
public Article(int reference, String title, String topic, public Article(int reference, String title, String topic,
@@ -82,8 +81,8 @@ public class Article implements Serializable {
this.state = state; this.state = state;
} }
@Id //@Id
@GeneratedValue(strategy=GenerationType.AUTO) //@GeneratedValue(strategy=GenerationType.AUTO)
public int getId() { public int getId() {
return id; return id;
} }
@@ -140,22 +139,23 @@ public class Article implements Serializable {
this.state = state; this.state = state;
} }
@ManyToMany(targetEntity=User.class) /*@ManyToMany(targetEntity=User.class)
@JoinTable( @JoinTable(
name="articles_referees_map", name="articles_referees_map",
joinColumns=@JoinColumn(name="user_id"), joinColumns=@JoinColumn(name="user_id"),
inverseJoinColumns=@JoinColumn(name="article_id") inverseJoinColumns=@JoinColumn(name="article_id")
) )*/
public Collection<User> getReferees(){ public Collection<User> getReferees(){
return referees; return this.referees;
//return em.createQuery("SELECT u FROM User u").getResultList();
} }
@ManyToMany(targetEntity=User.class) /*@ManyToMany(targetEntity=User.class)
@JoinTable( @JoinTable(
name="articles_pcmembers_map", name="articles_pcmembers_map",
joinColumns=@JoinColumn(name="user_id"), joinColumns=@JoinColumn(name="user_id"),
inverseJoinColumns=@JoinColumn(name="article_id") inverseJoinColumns=@JoinColumn(name="article_id")
) )*/
public Collection<User> getPCMembers(){ public Collection<User> getPCMembers(){
return pcMembers; return pcMembers;
} }
@@ -179,12 +179,12 @@ public class Article implements Serializable {
} }
} }
@ManyToOne(targetEntity=Conference.class) //@ManyToOne(targetEntity=Conference.class)
public Conference getConference(){ public Conference getConference(){
return conference; return conference;
} }
@ManyToOne(targetEntity=Conference.class) //@ManyToOne(targetEntity=Conference.class)
public void setConference(Conference conference){ public void setConference(Conference conference){
this.conference = conference; this.conference = conference;
} }

29
YACOSCore/ejbModule/org/yacos/core/article/ArticleManagerBean.java
View File

@@ -1,6 +1,8 @@
package org.yacos.core.article; package org.yacos.core.article;
import java.io.Serializable; import java.io.Serializable;
import java.util.ArrayList;
import java.util.Collection;
import java.util.List; import java.util.List;
import javax.ejb.Stateless; import javax.ejb.Stateless;
@@ -20,38 +22,49 @@ public class ArticleManagerBean implements IArticleManager, Serializable {
@PersistenceContext @PersistenceContext
EntityManager em; EntityManager em;
public ArticleManagerBean() { List<Article> articles;
public ArticleManagerBean() {
articles = new ArrayList<Article>();
} }
public void addArticle(Article a) { public void addArticle(Article a) {
em.persist(a); //em.persist(a);
articles.add(a);
} }
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
public List<Article> getArticles() { public List<Article> getArticles() {
return em.createQuery("from Article a ORDER BY a.title").getResultList(); //return em.createQuery("from Article a ORDER BY a.title").getResultList();
return articles;
} }
public void updateArticle(Integer id, Article newArticle) { public void updateArticle(Integer id, Article newArticle) {
removeArticle(getArticle(id)); removeArticle(getArticle(id));
newArticle.setId(id); newArticle.setId(id);
addArticle(newArticle); addArticle(newArticle);
em.flush(); //em.flush();
} }
public void removeArticle(Article a) { public void removeArticle(Article a) {
em.remove(a); //em.remove(a);
em.flush(); //em.flush();
articles.remove(a);
} }
public Article getArticle(Integer id) { public Article getArticle(Integer id) {
return em.find(Article.class, id); //return em.find(Article.class, id);
for (Article a : articles) {
if(a.getId()== id){
return a;
}
}
return null;
} }
public void assignArticleToPCMember(Article article,User pcMember){ public void assignArticleToPCMember(Article article,User pcMember){
article.assignToPCMember(pcMember); article.assignToPCMember(pcMember);
em.flush(); //em.flush();
} }
public List<User> getArticlePCMembers(Article article) { public List<User> getArticlePCMembers(Article article) {

46
YACOSCore/ejbModule/org/yacos/core/article/Delegation.java
View File

@@ -3,7 +3,10 @@
*/ */
package org.yacos.core.article; package org.yacos.core.article;
import java.io.Serializable;
import javax.persistence.Entity; import javax.persistence.Entity;
import javax.persistence.Id;
import javax.persistence.JoinColumn; import javax.persistence.JoinColumn;
import javax.persistence.ManyToOne; import javax.persistence.ManyToOne;
import org.yacos.core.users.User; import org.yacos.core.users.User;
@@ -12,24 +15,26 @@ import org.yacos.core.users.User;
* @author christiancorsano * @author christiancorsano
* *
*/ */
@Entity //@Entity
public class Delegation { public class Delegation implements Serializable {
@ManyToOne(targetEntity=Article.class) //@ManyToOne(targetEntity=Article.class)
@JoinColumn(name="article_id") //@JoinColumn(name="article_id")
private Article article; private Article article;
@ManyToOne(targetEntity=User.class) //@ManyToOne(targetEntity=User.class)
@JoinColumn(name="pcmember_id") //@JoinColumn(name="pcmember_id")
private User pcMember; private User pcMember;
@ManyToOne(targetEntity=User.class) //@ManyToOne(targetEntity=User.class)
@JoinColumn(name="referee_id") //@JoinColumn(name="referee_id")
private User referee; private User referee;
/** /**
* Article being evaluated through this delegation * Article being evaluated through this delegation
* @return the article * @return the article
*/ */
@ManyToOne(targetEntity=Article.class) //@ManyToOne(targetEntity=Article.class)
@JoinColumn(name="article_id") //@JoinColumn(name="article_id")
public Article getArticle() { public Article getArticle() {
return article; return article;
} }
@@ -37,8 +42,8 @@ public class Delegation {
* Define the article evaluated through this delegation * Define the article evaluated through this delegation
* @param article the article to set * @param article the article to set
*/ */
@ManyToOne(targetEntity=Article.class) //@ManyToOne(targetEntity=Article.class)
@JoinColumn(name="article_id") //@JoinColumn(name="article_id")
public void setArticle(Article article) { public void setArticle(Article article) {
this.article = article; this.article = article;
} }
@@ -46,8 +51,8 @@ public class Delegation {
* PCMember that delegated the article to a referee * PCMember that delegated the article to a referee
* @return the pcMember * @return the pcMember
*/ */
@ManyToOne(targetEntity=User.class) //@ManyToOne(targetEntity=User.class)
@JoinColumn(name="pcmember_id") //@JoinColumn(name="pcmember_id")
public User getPcMember() { public User getPcMember() {
return pcMember; return pcMember;
} }
@@ -55,8 +60,8 @@ public class Delegation {
* Set PCMember that delegated the article to a referee * Set PCMember that delegated the article to a referee
* @param pcMember the pcMember to set * @param pcMember the pcMember to set
*/ */
@ManyToOne(targetEntity=User.class) //@ManyToOne(targetEntity=User.class)
@JoinColumn(name="pcmember_id") //@JoinColumn(name="pcmember_id")
public void setPcMember(User pcMember) { public void setPcMember(User pcMember) {
this.pcMember = pcMember; this.pcMember = pcMember;
} }
@@ -64,8 +69,8 @@ public class Delegation {
* Get the referee that will evaluate this article * Get the referee that will evaluate this article
* @return the referee * @return the referee
*/ */
@ManyToOne(targetEntity=User.class) //@ManyToOne(targetEntity=User.class)
@JoinColumn(name="referee_id") //@JoinColumn(name="referee_id")
public User getReferee() { public User getReferee() {
return referee; return referee;
} }
@@ -73,11 +78,12 @@ public class Delegation {
* Get * Get
* @param referee the referee to set * @param referee the referee to set
*/ */
@ManyToOne(targetEntity=User.class) //@ManyToOne(targetEntity=User.class)
@JoinColumn(name="referee_id") //@JoinColumn(name="referee_id")
public void setReferee(User referee) { public void setReferee(User referee) {
this.referee = referee; this.referee = referee;
} }
} }

39
YACOSCore/ejbModule/org/yacos/core/article/Preference.java
View File

@@ -4,8 +4,7 @@
package org.yacos.core.article; package org.yacos.core.article;
import javax.persistence.Entity; import javax.persistence.Entity;
import javax.persistence.JoinColumn; import javax.persistence.Id;
import javax.persistence.ManyToOne;
import org.yacos.core.users.User; import org.yacos.core.users.User;
@@ -13,44 +12,54 @@ import org.yacos.core.users.User;
* @author christiancorsano * @author christiancorsano
* *
*/ */
@Entity //@Entity
public class Preference { public class Preference {
@ManyToOne(targetEntity=User.class) //@ManyToOne(targetEntity=User.class)
@JoinColumn(name="pcmember_id",nullable=false) //@JoinColumn(name="pcmember_id",nullable=false)
//@Id
private int id;
private User pcMember; private User pcMember;
@ManyToOne(targetEntity=Article.class) //@ManyToOne(targetEntity=Article.class)
@JoinColumn(name="article_id",nullable=false) //@JoinColumn(name="article_id",nullable=false)
private Article article; private Article article;
/** /**
* @return the pcMember * @return the pcMember
*/ */
@ManyToOne(targetEntity=User.class) //@ManyToOne(targetEntity=User.class)
@JoinColumn(name="pcmember_id",nullable=false) //@JoinColumn(name="pcmember_id",nullable=false)
public User getPcMember() { public User getPcMember() {
return pcMember; return pcMember;
} }
/** /**
* @param pcMember the pcMember to set * @param pcMember the pcMember to set
*/ */
@ManyToOne(targetEntity=User.class) //@ManyToOne(targetEntity=User.class)
@JoinColumn(name="pcmember_id",nullable=false) //@JoinColumn(name="pcmember_id",nullable=false)
public void setPcMember(User pcMember) { public void setPcMember(User pcMember) {
this.pcMember = pcMember; this.pcMember = pcMember;
} }
/** /**
* @return the article * @return the article
*/ */
@ManyToOne(targetEntity=Article.class) //@ManyToOne(targetEntity=Article.class)
@JoinColumn(name="article_id",nullable=false) //@JoinColumn(name="article_id",nullable=false)
public Article getArticle() { public Article getArticle() {
return article; return article;
} }
/** /**
* @param article the article to set * @param article the article to set
*/ */
@ManyToOne(targetEntity=Article.class) //@ManyToOne(targetEntity=Article.class)
@JoinColumn(name="article_id",nullable=false) //@JoinColumn(name="article_id",nullable=false)
public void setArticle(Article article) { public void setArticle(Article article) {
this.article = article; this.article = article;
} }
public int getId() {
return id;
}
public void setId(int id) {
this.id = id;
}
} }