Policy failures:

Code warning
- failed on resource PCMemberBean.java. Reason: The import org.yacos.core.article.Preference.PreferenceType is never used, line 
Override reason:   
d
This commit is contained in:
Maxime Dagnicourt
2008-02-11 16:51:56 +00:00
parent e71442720f
commit 884c2d01d5
4 changed files with 50 additions and 19 deletions

View File

@@ -31,10 +31,11 @@
<br/> main author: ${article.mainAuthor.firstName}{article.mainAuthor.lastName} <br/> main author: ${article.mainAuthor.firstName}{article.mainAuthor.lastName}
<br/><a href="${article.URL_article}">download the article</a> <br/><a href="${article.URL_article}">download the article</a>
</p> </p>
<br/>
<b>members of the conference</b> <b>members of the conference</b>
<table id="members"> <table border="1px" id="members">
<tr> <tr>
<th>name</th> <th>name</th>
<th>preference</th> <th>preference</th>
@@ -44,17 +45,17 @@
<c:forEach var="m" items="${members}"> <c:forEach var="m" items="${members}">
<tr> <tr>
<td>${m.firstName} ${m.lastName}(0)</td> <td>${m.firstName} ${m.lastName}(0)</td>
<td>???</td> <td>${m.preference}</td>
<td>0</td> <td>${m.nbArticles}</td>
<td><a href="" onclick="addMember('${m.login}', '${article.id}');"/>add</a></td> <td><a href="" onclick="addMember('${m.login}', '${article.id}');"/>add</a></td>
</tr> </tr>
</c:forEach> </c:forEach>
</table> </table>
<select> <select>
<c:forEach var="am" items="${ArticleMembers}"> <c:forEach var="am" items="${articleMembers}">
<option value="${m.login}"> <option value="${am.login}">
${m.firstName} ${m.lastName}(0) ${am.firstName} ${am.lastName}
</option> </option>
</c:forEach> </c:forEach>
</select> </select>

View File

@@ -213,7 +213,6 @@
<property name="conferenceManager" ref="conferenceManager" /> <property name="conferenceManager" ref="conferenceManager" />
</bean> </bean>
<bean id="ListEvaluationController" <bean id="ListEvaluationController"
class="org.yacos.web.PCmember.controller.ListEvaluationController"> class="org.yacos.web.PCmember.controller.ListEvaluationController">
<property name="articleManager" ref="articleManager" /> <property name="articleManager" ref="articleManager" />

View File

@@ -1,20 +1,20 @@
package org.yacos.web.chairman.controller; package org.yacos.web.chairman.controller;
import java.util.ArrayList;
import java.util.HashMap; import java.util.HashMap;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import javax.servlet.http.HttpSession;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import org.directwebremoting.WebContextFactory;
import org.springframework.web.servlet.ModelAndView; import org.springframework.web.servlet.ModelAndView;
import org.springframework.web.servlet.mvc.Controller; import org.springframework.web.servlet.mvc.Controller;
import org.yacos.core.article.Article; import org.yacos.core.article.Article;
import org.yacos.core.article.IArticleManager; import org.yacos.core.article.IArticleManager;
import org.yacos.core.article.Preference;
import org.yacos.core.conferences.Conference; import org.yacos.core.conferences.Conference;
import org.yacos.core.conferences.IConferenceManager; import org.yacos.core.conferences.IConferenceManager;
import org.yacos.core.users.IUserManager; import org.yacos.core.users.IUserManager;
@@ -62,15 +62,38 @@ public class DispatchArticleController implements Controller{
//list of the member who have this article //list of the member who have this article
List<User> articleMembers = userManager.getPCMemberForArticle(article.getId()); List<User> articleMembers = userManager.getPCMemberForArticle(article.getId());
logger.debug("nombre de memebre prour l'article = "+articleMembers.size());
Map<String,Integer> nbArticles = new HashMap<String,Integer>(); //List members for webpage
List<PCMemberBean> membersWeb = new ArrayList<PCMemberBean>();
//list of member who have'nt this article //list of member who have'nt this article
List<User> members = userManager.getUsers(conf.getId(),RoleType.PCMEMBER); List<User> members = userManager.getUsers(conf.getId(),RoleType.PCMEMBER);
for (User user : members) {
PCMemberBean member = new PCMemberBean();
member.setFirstName(user.getFirstName());
member.setLastName(user.getLastName());
member.setLogin(user.getLogin());
Preference pref = articleManager.getPreferenceForUserAndArticle(article.getId(), user.getLogin());
if (pref != null){
String prefType = pref.getPreferenceType().toString();
member.setPreference(prefType);
}else {
member.setPreference(Preference.PreferenceType.INDIFFERENT.toString());
}
int nb = 0;
List<Article> articles = articleManager.getArticlesOfMember(conf.getId(), user.getLogin());
if(articles != null){
nb = articles.size();
}
member.setNbArticles(nb);
membersWeb.add(member);
}
Map<String,Object> model = new HashMap<String,Object>(); Map<String,Object> model = new HashMap<String,Object>();
model.put("articleMembers",articleMembers); model.put("articleMembers",articleMembers);
model.put("members", members); model.put("members", membersWeb);
model.put("article", article); model.put("article", article);
return new ModelAndView("dispatchArticle", model); return new ModelAndView("dispatchArticle", model);

View File

@@ -1,11 +1,13 @@
package org.yacos.web.chairman.controller; package org.yacos.web.chairman.controller;
import org.yacos.core.article.Preference.PreferenceType;
public class PCMemberBean { public class PCMemberBean {
private String login; private String login;
private String firstName; private String firstName;
private String lastName; private String lastName;
private String Preference; private String Preference;
private String nbArticles; private int nbArticles;
public PCMemberBean() { public PCMemberBean() {
super(); super();
@@ -29,16 +31,22 @@ public class PCMemberBean {
public void setLastName(String lastName) { public void setLastName(String lastName) {
this.lastName = lastName; this.lastName = lastName;
} }
public String getPreference() { public String getPreference() {
return Preference; return Preference;
} }
public void setPreference(String preference) { public void setPreference(String preference) {
Preference = preference; Preference = preference;
} }
public String getNbArticles() {
return nbArticles; public void setNbArticles(int nbArticles) {
}
public void setNbArticles(String nbArticles) {
this.nbArticles = nbArticles; this.nbArticles = nbArticles;
} }
public int getNbArticles() {
return nbArticles;
}
} }