christiancorsano/yacos
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

mtn un evaluation est liee a un article , par contre une erreur lors de creation de report.

Browse Source 
Policy failures:   
Code warning
- failed on resource EvaluationController.java. Reason: ArrayList is a raw type. References to generic type ArrayList<E> should be parameterized, line 105
- failed on resource EvaluationController.java. Reason: The local variable idd is never read, line 129
- failed on resource EvaluationController.java. Reason: Type safety: The expression of type ArrayList needs unchecked conversion to conform to List<Rating>, line 10
Override reason:   
o(∩_∩)o
This commit is contained in:
Jialin Wang
2008-02-05 00:28:25 +00:00
parent dd9e8ec9a7
commit 936e7ef80d
4 changed files with 20 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
YACOSWeb/WebContent/WEB-INF/jsp/evaluation.jsp
View File

@@ -6,12 +6,9 @@
<h2 align="center"><fmt:message key="evaluation.title"/></h2>
<form:form method="post" commandName="evaluationForm"> <form:form method="post" commandName="evaluationForm">
<h4 align="center"><fmt:message key="evaluation.title"/>: ${evaluationForm.title}</h4>
<br>
<table> <table>
<c:forEach items="${evaluationForm.simpleRatings}" var="criterion" varStatus="j"> <c:forEach items="${evaluationForm.simpleRatings}" var="criterion" varStatus="j">

2
YACOSWeb/WebContent/WEB-INF/jsp/listEvaluation.jsp
View File

@@ -3,7 +3,7 @@
<html> <html>
<head></head> <head></head>
<body> <body>
<h2><fmt:message key="evaluation.choose"/></h2> <h2 align="center"><fmt:message key="evaluation.choose"/></h2>
<c:forEach items="${listArticle}" var="article"> <c:forEach items="${listArticle}" var="article">
<ul class="article"> <ul class="article">
<li class="title">Title: <a href="<c:url value="${article.URL_article}"/>">${article.title}</a></li> <li class="title">Title: <a href="<c:url value="${article.URL_article}"/>">${article.title}</a></li>

11
YACOSWeb/src/org/yacos/web/PCmember/controller/EvaluationController.java
View File

@@ -65,6 +65,10 @@ public class EvaluationController extends SimpleFormController {
criterionList.add(c1); criterionList.add(c1);
criterionList.add(c2); criterionList.add(c2);
String id=request.getParameter("id");
Article art=articleManager.getArticle(Integer.parseInt(id));
String title=art.getTitle();
FormEvaluation fe=new FormEvaluation(); FormEvaluation fe=new FormEvaluation();
List<SimpleCriterion> liste=new ArrayList<SimpleCriterion>(); List<SimpleCriterion> liste=new ArrayList<SimpleCriterion>();
@@ -81,6 +85,7 @@ public class EvaluationController extends SimpleFormController {
fe.setSimpleRatings(liste); fe.setSimpleRatings(liste);
fe.setCommentAuthor("no comment by author"); fe.setCommentAuthor("no comment by author");
fe.setCommentPCMember("no comment by pc member"); fe.setCommentPCMember("no comment by pc member");
fe.setTitle(title);
return fe; return fe;
} }
@@ -122,8 +127,12 @@ public class EvaluationController extends SimpleFormController {
} }
int idd=Integer.parseInt(id); int idd=Integer.parseInt(id);
/*System.out.println(idd);
if (!listeRating.isEmpty()) { System.out.println("not empty liste");}
System.out.println("current user is "+current.getLogin());*/
Report rpt =new Report(commentPCMember,commentAuthor,listeRating,current,article); Report rpt =new Report(commentPCMember,commentAuthor,listeRating,current,article);
//evaluationManager.addReport(idd, commentPCMember, commentAuthor, listeRating, current.getLogin()); // evaluationManager.addReport(idd, commentPCMember, commentAuthor, listeRating, current.getLogin());
request.getSession().setAttribute("report", rpt); request.getSession().setAttribute("report", rpt);
//Map<String, Report> model1 = new HashMap<String, Report>(); //Map<String, Report> model1 = new HashMap<String, Report>();
//model1.put("report", rpt); //model1.put("report", rpt);

7
YACOSWeb/src/org/yacos/web/PCmember/form/FormEvaluation.java
View File

@@ -11,8 +11,15 @@ public class FormEvaluation {
private List<SimpleCriterion> simpleRatings = new ArrayList<SimpleCriterion>(); private List<SimpleCriterion> simpleRatings = new ArrayList<SimpleCriterion>();
private String commentPCMember; private String commentPCMember;
private String commentAuthor; private String commentAuthor;
private String title;
public String getTitle() {
return title;
}
public void setTitle(String title) {
this.title = title;
}
public String getCommentPCMember() { public String getCommentPCMember() {
return commentPCMember; return commentPCMember;
} }