Policy failures:

Code warning
- failed on resource DispatchArticleController.java. Reason: ArrayList is a raw type. References to generic type ArrayList<E> should be parameterized, line 37
- failed on resource DispatchArticleController.java. Reason: ArrayList is a raw type. References to generic type ArrayList<E> should be parameterized, line 38
- failed on resource DispatchArticleController.java. Reason: ArrayList is a raw type. References to generic type ArrayList<E> should be parameterized, line 62
- failed on resource DispatchArticleController.java. Reason: ArrayList is a raw type. References to generic type ArrayList<E> should be parameterized, line 63
- failed on resource DispatchArticleController.java. Reason: The local variable article is never read, line 58
... and more.  
Override reason:   
max
This commit is contained in:
Maxime Dagnicourt
2007-12-17 11:09:21 +00:00
parent d5c6500fb0
commit bbf511cf69

View File

@@ -2,46 +2,81 @@ package org.yacos.web.PCmember.controller;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Collection; import java.util.Collection;
import java.util.Date;
import java.util.List;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpServletResponse;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import org.springframework.validation.BindException;
import org.springframework.web.servlet.ModelAndView; import org.springframework.web.servlet.ModelAndView;
import org.springframework.web.servlet.mvc.Controller; import org.springframework.web.servlet.mvc.SimpleFormController;
import org.yacos.core.article.Article; import org.yacos.core.article.Article;
import org.yacos.core.conferences.Conference; import org.yacos.core.article.IArticleManager;
import org.yacos.core.conferences.IConferenceManager; import org.yacos.core.users.Role;
import org.yacos.core.users.*; import org.yacos.core.users.User;
import org.yacos.web.PCmember.form.FormDispatcher;
public class DispatchArticleController implements Controller{ public class DispatchArticleController extends SimpleFormController{
protected final Log logger = LogFactory.getLog(getClass()); protected final Log logger = LogFactory.getLog(getClass());
private IConferenceManager conferenceManager; private IArticleManager articleManager;
public IArticleManager getArticleManager() {
public IConferenceManager getConferenceManager() { return articleManager;
return conferenceManager; }
public void setArticleManager(IArticleManager articleManager) {
this.articleManager = articleManager;
} }
public void setConferenceManager(IConferenceManager conferenceManager) {
this.conferenceManager = conferenceManager;
protected Object formBackingObject(HttpServletRequest request) {
logger.info("Returning dispatcher view");
/*test temporaire !!!!*/
Article a = new Article(1,"title1","topic","url","autor",new ArrayList(),1);
Article a2 = new Article(2,"title2","topic","url","autor",new ArrayList(),1);
Collection<Article> articles = new ArrayList<Article>();
articles.add(a);
articles.add(a2);
User m = new User("max","max","maxime","dagnicourt","ipint","m@truc.fr",new ArrayList<Role>());
User m2 = new User("bob","bob","bob","dupont","lifl","b@bb.fr",new ArrayList<Role>());
Collection<User> members = new ArrayList<User>();
members.add(m);
members.add(m2);
request.getSession().setAttribute("members",members);
request.getSession().setAttribute("articles",articles);
/*fin de test*/
return new FormDispatcher();
} }
private IUsersManager userManager; protected ModelAndView onSubmit(HttpServletRequest request,
HttpServletResponse response,
Object formDispatcher, BindException errors) throws Exception {
public IUsersManager getUserManager() { FormDispatcher fd = (FormDispatcher)formDispatcher;
return userManager; Article article = articleManager.getArticle(fd.getIdArticle());
/*test temporaire !!!!*/
Article a = new Article(1,"title1","topic","url","autor",new ArrayList(),1);
Article a2 = new Article(2,"title2","topic","url","autor",new ArrayList(),1);
Collection<Article> articles = new ArrayList<Article>();
articles.add(a);
articles.add(a2);
User m = new User("max","max","maxime","dagnicourt","ipint","m@truc.fr",new ArrayList<Role>());
User m2 = new User("bob","bob","bob","dupont","lifl","b@bb.fr",new ArrayList<Role>());
Collection<User> members = new ArrayList<User>();
members.add(m);
members.add(m2);
request.getSession().setAttribute("members",members);
/*fin de test*/
return new ModelAndView("dispachArticle", "articles",articles);
} }
public void setUserManager(IUsersManager userManager) { /*public ModelAndView handleRequest(HttpServletRequest arg0,
this.userManager = userManager;
}
public ModelAndView handleRequest(HttpServletRequest arg0,
HttpServletResponse arg1) throws Exception { HttpServletResponse arg1) throws Exception {
Date date = new Date(); Date date = new Date();
//Conference conf = new Conference(1,"lalal","lalala","lalala",date,date,date,date,date); //Conference conf = new Conference(1,"lalal","lalala","lalala",date,date,date,date,date);
@@ -63,6 +98,6 @@ public class DispatchArticleController implements Controller{
members.add(m2); members.add(m2);
arg0.getSession().setAttribute("members",members); arg0.getSession().setAttribute("members",members);
return new ModelAndView("dispatchArticle","articles",articles); return new ModelAndView("dispatchArticle","articles",articles);
} }*/
} }