From efa973e5943bb9ed404691debf456101540d290f Mon Sep 17 00:00:00 2001 From: Maxime Dagnicourt Date: Tue, 5 Feb 2008 08:57:34 +0000 Subject: [PATCH] Policy failures: Code warning - failed on resource ArticleManagerBean.java. Reason: The field ArticleManagerBean.sc is never read locally, line 36 - failed on resource ArticleManagerBean.java. Reason: The import org.yacos.core.users.Role.RoleType is never used, line 21 - failed on resource ArticleManagerBean.java. Reason: The import org.yacos.core.users.Role is never used, line 18 - failed on resource ArticleManagerBean.java. Reason: The import org.yacos.core.users.RolePK is never used, line 1 Override reason: d --- .../core/article/ArticleManagerBean.java | 21 +++---------------- 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/YACOSCore/ejbModule/org/yacos/core/article/ArticleManagerBean.java b/YACOSCore/ejbModule/org/yacos/core/article/ArticleManagerBean.java index 6845236..9cfc46e 100644 --- a/YACOSCore/ejbModule/org/yacos/core/article/ArticleManagerBean.java +++ b/YACOSCore/ejbModule/org/yacos/core/article/ArticleManagerBean.java @@ -104,30 +104,15 @@ public class ArticleManagerBean implements IArticleManager, Serializable { public void assignArticleToPCMember(Integer articleId,String memberId){ Article article = this.getArticle(articleId); User PCMember = em.find(User.class, memberId); - article.addPCMember(PCMember); - RolePK rolePK = new RolePK(PCMember,RoleType.PCMEMBER,article.getConference()); - if(em.find(Role.class, rolePK)==null){ - // Add the role : this should be the responsibility of ConferenceManager ... - Role pcMemberRole = new Role(); - pcMemberRole.setType(RoleType.PCMEMBER); - pcMemberRole.setUser(PCMember); - pcMemberRole.setConference(article.getConference()); - em.persist(pcMemberRole); - } - this.updateArticle(article); - } public List getArticlePCMembers(Integer articleId) { - - Article article = this.getArticle(articleId); - List users = (List)article.getPCMembers(); - return users; - - + Article article = this.getArticle(articleId); + List users = (List)article.getPCMembers(); + return users; } public void delegateArticleToReferee(Integer articleId, String refereeId, String memberId){